Improve io::Error::downcast
#149521
Merged
Improve io::Error::downcast
#149521
+12
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
Collaborator
This comment has been minimized.
This comment has been minimized.
a1phyr
force-pushed
the
improve_io_error
branch
from
3f5c449 to
126b4d2
Compare
Member
|
The |
Contributor
Author
|
Wow, I somehow managed to convince myself that the Given the current situation, removing this box is probably not beneficial indeed. I'll remove the second commit. |
a1phyr
force-pushed
the
improve_io_error
branch
from
126b4d2 to
7de190a
Compare
a1phyr
changed the title
io::Error: avoid double-boxing of "custom" variant on 32 bits targetsio::Error::downcast: avoid reallocation in case of failure
a1phyr
changed the title
io::Error::downcast: avoid reallocation in case of failureio::Error::downcast:
Member
|
@bors r+ |
Collaborator
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Dec 3, 2025
Improve `io::Error::downcast` Rewrite this function to help to compiler understand what is going on here.
bors
added a commit
that referenced
this pull request
Dec 3, 2025
Rollup of 9 pull requests Successful merges: - #147841 (Fix ICE when applying test macro to crate root) - #149501 (CTFE: avoid emitting a hard error on generic normalization failures) - #149517 (Implement blessing for tidy alphabetical check) - #149521 (Improve `io::Error::downcast`) - #149545 (fix the check for which expressions read never type) - #149549 (Regression test for system register `ttbr0_el2`) - #149579 (Motor OS: fix compile error) - #149595 (Tidying up `tests/ui/issues` tests [2/N]) - #149597 (Revert "implement and test `Iterator::{exactly_one, collect_array}`") r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
that referenced
this pull request
Dec 4, 2025
Rollup of 9 pull requests Successful merges: - #147841 (Fix ICE when applying test macro to crate root) - #149501 (CTFE: avoid emitting a hard error on generic normalization failures) - #149517 (Implement blessing for tidy alphabetical check) - #149521 (Improve `io::Error::downcast`) - #149545 (fix the check for which expressions read never type) - #149549 (Regression test for system register `ttbr0_el2`) - #149579 (Motor OS: fix compile error) - #149595 (Tidying up `tests/ui/issues` tests [2/N]) - #149597 (Revert "implement and test `Iterator::{exactly_one, collect_array}`") r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
that referenced
this pull request
Dec 4, 2025
Rollup of 10 pull requests Successful merges: - #149521 (Improve `io::Error::downcast`) - #149544 (Only apply `no_mangle_const_items`'s suggestion to plain const items) - #149545 (fix the check for which expressions read never type) - #149570 (rename cortex-ar references to unified aarch32) - #149574 (Batched compiletest Config fixups) - #149579 (Motor OS: fix compile error) - #149595 (Tidying up `tests/ui/issues` tests [2/N]) - #149597 (Revert "implement and test `Iterator::{exactly_one, collect_array}`") - #149608 (Allow PowerPC spe_acc as clobber-only register) - #149610 (Implement benchmarks for uN::{gather,scatter}_bits) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Dec 4, 2025
Rollup merge of #149521 - a1phyr:improve_io_error, r=joboet Improve `io::Error::downcast` Rewrite this function to help to compiler understand what is going on here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrite this function to help to compiler understand what is going on here.